[TensorIR][M2a] Decompose-Reduction #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectrometerHBH
requested review from
areusch,
comaniac,
Hzfengsy,
jroesch,
junrushao,
kparzysz-quic,
masahi,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
29 tasks
|
Sorry I have a deadline on Monday...Will review do after that |
Hzfengsy
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 22, 2021
junrushao
reviewed
Sep 28, 2021
junrushao
reviewed
Sep 28, 2021
junrushao
reviewed
Sep 28, 2021
junrushao
reviewed
Sep 28, 2021
junrushao
reviewed
Sep 28, 2021
junrushao
reviewed
Sep 28, 2021
Comment on lines
+74
to
+81
| Stmt VisitStmt_(const SeqStmtNode* seq) final { | ||
| Array<Stmt> new_stmts; | ||
| new_stmts.reserve(seq->seq.size()); | ||
| for (const Stmt& old_stmt : seq->seq) { | ||
| new_stmts.push_back(VisitStmt(old_stmt)); | ||
| } | ||
| return SeqStmt::Flatten(new_stmts); | ||
| } |
There was a problem hiding this comment.
Why do we need special handling of SeqStmt btw?
|
@spectrometerHBH Sorry for the delay! I think I finally did a complete with the code review. Let me know if it makes sense to you |
@junrushao1994 Thanks！I might be slow to response in the next 2 days |
|
Would be nice if we could get this merged this week or weekend :-) |
junrushao
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
@spectrometerHBH and I discussed for quite a few days and finally addressed all my concerns. Thanks for the great effort!
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the `decompose-reduction` scheduling primitive. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This PR is part of the TensorIR upstreaming effort (apache#7527), which adds the `decompose-reduction` scheduling primitive. Co-authored-by: Junru Shao <junrushao1994@gmail.com> Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com> Co-authored-by: Hongyi Jin <3231950289@qq.com> Co-authored-by: Wuwei Lin <wuwei@apache.org> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the TensorIR upstreaming effort (#7527), which adds the following schedule primitives:
decompose_reduction
Co-authored-by: Junru Shao junrushao1994@gmail.com
Co-authored-by: Ruihang Lai lairuihangdongdong@qq.com
Co-authored-by: Hongyi Jin 3231950289@qq.com
Co-authored-by: Wuwei Lin wuwei@apache.org
Co-authored-by: Siyuan Feng Hzfengsy@sjtu.edu.cn